Skip to content

Attempt to reduce intermittent failures in the "multiple render() on the same canvas" unit-test #12171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2020
Merged

Attempt to reduce intermittent failures in the "multiple render() on the same canvas" unit-test #12171

merged 1 commit into from
Aug 4, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

This patch should hopefully remove the intermittent unit-test failure, by using the same optionalContentConfigPromise for both renderTasks and thus get more predictable timing behaviour.

@Snuffleupagus
Attempt to reduce intermittent failures in the "multiple render() on …
13e44c0 
…the same canvas" unit-test

This patch should *hopefully* remove the intermittent unit-test failure, by using the *same* `optionalContentConfigPromise` for both `renderTask`s and thus get more predictable timing behaviour.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/39c3e2e634755b3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/db158c893274cf5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/39c3e2e634755b3/output.txt

Total script time: 3.84 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/db158c893274cf5/output.txt

Total script time: 4.92 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/4f7f620d87da3ab/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/24d0051a3801282/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/4f7f620d87da3ab/output.txt

Total script time: 3.85 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/24d0051a3801282/output.txt

Total script time: 4.62 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/9a657ac1b671874/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/94052c570547f05/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/9a657ac1b671874/output.txt

Total script time: 3.93 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/94052c570547f05/output.txt

Total script time: 4.76 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/532e8d272a6f1d7/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6210143981aab08/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/6210143981aab08/output.txt

Total script time: 3.94 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/532e8d272a6f1d7/output.txt

Total script time: 4.82 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c53d69ce8038547/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/41fbe202a3b7234/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/c53d69ce8038547/output.txt

Total script time: 3.88 mins

  • Unit Tests: FAILED

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/41fbe202a3b7234/output.txt

Total script time: 4.69 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b126ae4fcf45a73/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3f76d65e21648ce/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/b126ae4fcf45a73/output.txt

Total script time: 3.84 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2020

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/3f76d65e21648ce/output.txt

Total script time: 4.68 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 02bcc25 into mozilla:master Aug 4, 2020
@timvandermeij
Copy link
Contributor

Nice find; thank you for getting rid of all those pesky intermittents the last few days!

@timvandermeij timvandermeij mentioned this pull request Aug 4, 2020
Closed
7 tasks
@Snuffleupagus Snuffleupagus deleted the unittest-shall_fail_rendering branch August 4, 2020 22:05
@Snuffleupagus
Copy link
Collaborator Author

Nice find; thank you for getting rid of all those pesky intermittents the last few days!

No problem; in the event that this patch still isn't enough, there's additional things can be done to really fix the test. However that may render it somewhat "messy", hence I went with a simpler approach for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij